Update fnAddTr.js - Fix - Showing invisible columns

Showing not visible columns and returning the result of fnAddData, now using the actual TR.
Also fixes the problem described at [#24](https://github.com/DataTables/Plugins/pull/24):

> Okay - I agree - there is an issue here. This pull request isn't quite the right fix for the issue, so I'll not pull it in, and I'm not going to look at it myself as it should be addressed in 1.10 - but yes, there is an issue with this existing plug-in that if yourself or anyone else wishes to fix, whereby the added TR is kept, then I'll happily pull it in.
> 
> Good to hear that the plug-in works for you though :-)

And [#26](https://github.com/DataTables/Plugins/pull/26):

>I'm afraid this still isn't quite right - it needs to put the hidden cell nodes into an array like fnSetColumnVis does so they can be readied in future: https://github.com/DataTables/DataTables/blob/master/media/src/api/api.methods.js#L1097
pull/27/head
globalinnovation 12 years ago
parent 23872d168b
commit 73201816cb

@ -14,14 +14,14 @@ $.fn.dataTableExt.oApi.fnAddTr = function ( oSettings, nTr, bRedraw ) {
{ {
bRedraw = true; bRedraw = true;
} }
var nTds = nTr.getElementsByTagName('td'); var nTds = nTr.getElementsByTagName('td');
if ( nTds.length != oSettings.aoColumns.length ) if ( nTds.length != oSettings.aoColumns.length )
{ {
alert( 'Warning: not adding new TR - columns and TD elements must match' ); alert( 'Warning: not adding new TR - columns and TD elements must match' );
return; return;
} }
var aData = []; var aData = [];
var aInvisible = []; var aInvisible = [];
for ( var i=0 ; i<nTds.length ; i++ ) for ( var i=0 ; i<nTds.length ; i++ )
@ -32,19 +32,22 @@ $.fn.dataTableExt.oApi.fnAddTr = function ( oSettings, nTr, bRedraw ) {
aInvisible.push( i ); aInvisible.push( i );
} }
} }
for ( var i = (aInvisible.length - 1) ; i >= 0 ; i-- )
{
nTds[aInvisible[i]].remove();
}
/* Add the data and then replace DataTable's generated TR with ours */ /* Add the data and then replace DataTable's generated TR with ours */
var iIndex = this.oApi._fnAddData( oSettings, aData ); var iIndex = this.oApi._fnAddData( oSettings, aData );
nTr._DT_RowIndex = iIndex; nTr._DT_RowIndex = iIndex;
oSettings.aoData[ iIndex ].nTr = nTr; oSettings.aoData[ iIndex ].nTr = nTr;
oSettings.aiDisplay = oSettings.aiDisplayMaster.slice(); oSettings.aiDisplay = oSettings.aiDisplayMaster.slice();
// Hidding invisible columns
for ( var i = (aInvisible.length - 1) ; i >= 0 ; i-- )
{
oSettings.aoData[iIndex]._anHidden[ i ] = nTds[aInvisible[i]];
nTr.removeChild( nTds[aInvisible[i]] );
}
// Redraw
if ( bRedraw ) if ( bRedraw )
{ {
this.oApi._fnReDraw( oSettings ); this.oApi._fnReDraw( oSettings );

Loading…
Cancel
Save