|
|
|
@ -1,10 +1,10 @@
|
|
|
|
package gitflamecivalidator
|
|
|
|
package gitlabcivalidator
|
|
|
|
|
|
|
|
|
|
|
|
import (
|
|
|
|
import (
|
|
|
|
"fmt"
|
|
|
|
"fmt"
|
|
|
|
"gopkg.in/yaml.v3"
|
|
|
|
"gopkg.in/yaml.v3"
|
|
|
|
"strings"
|
|
|
|
"strings"
|
|
|
|
"tea.gitpark.ru/Azaki/ci_validator/errors"
|
|
|
|
"tea.gitpark.ru/Azaki/CI_VALIDATOR/errors"
|
|
|
|
"time"
|
|
|
|
"time"
|
|
|
|
)
|
|
|
|
)
|
|
|
|
|
|
|
|
|
|
|
|
@ -31,19 +31,19 @@ func ValidateGitLabCIFile(content string, opts ValidationOptions) error {
|
|
|
|
err := yaml.Unmarshal([]byte(content), &root)
|
|
|
|
err := yaml.Unmarshal([]byte(content), &root)
|
|
|
|
if err != nil {
|
|
|
|
if err != nil {
|
|
|
|
validationErr.AddDetailWithSpan(errors.ErrYamlSyntax,
|
|
|
|
validationErr.AddDetailWithSpan(errors.ErrYamlSyntax,
|
|
|
|
fmt.Sprintf("YAML parsing error: %v", err),
|
|
|
|
fmt.Sprintf("ошибка синтаксического анализа YAML: %v", err),
|
|
|
|
0, 0, 0, 0)
|
|
|
|
0, 0, 0, 0)
|
|
|
|
return validationErr
|
|
|
|
return validationErr
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if len(root.Content) == 0 {
|
|
|
|
if len(root.Content) == 0 {
|
|
|
|
validationErr.AddDetailWithSpan(errors.ErrYamlSyntax,
|
|
|
|
validationErr.AddDetailWithSpan(errors.ErrYamlSyntax,
|
|
|
|
".gitflame-ci.yml file is empty or does not contain valid data",
|
|
|
|
"файл .gitlab-ci.yml пуст или не содержит допустимых данных",
|
|
|
|
0, 0, 0, 0)
|
|
|
|
0, 0, 0, 0)
|
|
|
|
return validationErr
|
|
|
|
return validationErr
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if root.Kind != yaml.DocumentNode || len(root.Content) == 0 {
|
|
|
|
if root.Kind != yaml.DocumentNode || len(root.Content) == 0 {
|
|
|
|
validationErr.AddDetailWithSpan(errors.ErrYamlSyntax,
|
|
|
|
validationErr.AddDetailWithSpan(errors.ErrYamlSyntax,
|
|
|
|
"invalid YAML format: a root object was expected",
|
|
|
|
"некорректный формат YAML: ожидался корневой объект",
|
|
|
|
0, 0, 0, 0)
|
|
|
|
0, 0, 0, 0)
|
|
|
|
return validationErr
|
|
|
|
return validationErr
|
|
|
|
}
|
|
|
|
}
|
|
|
|
@ -75,7 +75,6 @@ func ValidateGitLabCIFile(content string, opts ValidationOptions) error {
|
|
|
|
validateStages(cfg, validationErr)
|
|
|
|
validateStages(cfg, validationErr)
|
|
|
|
validateVariables(cfg, validationErr)
|
|
|
|
validateVariables(cfg, validationErr)
|
|
|
|
validateIncludeRules(cfg, validationErr)
|
|
|
|
validateIncludeRules(cfg, validationErr)
|
|
|
|
checkFinalEmptyLine(content, validationErr)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
if !validationErr.IsEmpty() {
|
|
|
|
if !validationErr.IsEmpty() {
|
|
|
|
return validationErr
|
|
|
|
return validationErr
|
|
|
|
@ -154,123 +153,46 @@ func validateStages(cfg *GitLabCIConfig, ve *errors.ValidationError) {
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
// validateVariablesMap проверяет карту переменных varsMap, используя данные из YAML‑узла varsNode для получения позиций.
|
|
|
|
func validateVariables(cfg *GitLabCIConfig, ve *errors.ValidationError) {
|
|
|
|
func validateVariablesMap(varsMap map[string]interface{}, varsNode *yaml.Node, ve *errors.ValidationError, posGetter func(varName string) (int, int)) {
|
|
|
|
if cfg.Variables == nil {
|
|
|
|
|
|
|
|
return
|
|
|
|
|
|
|
|
}
|
|
|
|
|
|
|
|
varsMap, ok := cfg.Variables.(map[string]interface{})
|
|
|
|
|
|
|
|
if !ok {
|
|
|
|
|
|
|
|
ve.AddDetailWithSpan(errors.ErrVariablesInvalid, errors.ErrorMessages[errors.ErrVariablesInvalid], 0, 0, 0, 0)
|
|
|
|
|
|
|
|
return
|
|
|
|
|
|
|
|
}
|
|
|
|
allowedKeys := map[string]struct{}{
|
|
|
|
allowedKeys := map[string]struct{}{
|
|
|
|
"value": {},
|
|
|
|
"value": {},
|
|
|
|
"description": {},
|
|
|
|
"description": {},
|
|
|
|
"expand": {},
|
|
|
|
"expand": {},
|
|
|
|
"options": {},
|
|
|
|
"options": {},
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
for varName, val := range varsMap {
|
|
|
|
// Проходим по всем ключам, определённым в YAML‑узле
|
|
|
|
if isScalar(val) {
|
|
|
|
for i := 0; i < len(varsNode.Content)-1; i += 2 {
|
|
|
|
if len(varName) > MaxVariableNameLength {
|
|
|
|
keyNode := varsNode.Content[i]
|
|
|
|
ve.AddDetailWithSpan(errors.ErrVariableNameTooLong, fmt.Sprintf(errors.ErrorMessages[errors.ErrVariableNameTooLong], varName),
|
|
|
|
varName := keyNode.Value
|
|
|
|
0, 0, 0, 0,
|
|
|
|
// Получаем позицию для этой переменной через posGetter.
|
|
|
|
|
|
|
|
line, col := posGetter(varName)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
// Проверяем длину имени переменной
|
|
|
|
|
|
|
|
if len(varName) > MaxVariableNameLength {
|
|
|
|
|
|
|
|
ve.AddDetailWithSpan(
|
|
|
|
|
|
|
|
errors.ErrVariableNameTooLong,
|
|
|
|
|
|
|
|
fmt.Sprintf(errors.ErrorMessages[errors.ErrVariableNameTooLong], varName),
|
|
|
|
|
|
|
|
line, col, line, col+len(varName),
|
|
|
|
|
|
|
|
)
|
|
|
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
// Проверяем, что значение переменной присутствует и корректно
|
|
|
|
|
|
|
|
if val, exists := varsMap[varName]; exists {
|
|
|
|
|
|
|
|
if !isScalar(val) {
|
|
|
|
|
|
|
|
ve.AddDetailWithSpan(
|
|
|
|
|
|
|
|
errors.ErrVariableInvalid,
|
|
|
|
|
|
|
|
fmt.Sprintf(errors.ErrorMessages[errors.ErrVariableInvalid], varName),
|
|
|
|
|
|
|
|
line, col, line, col+len(varName),
|
|
|
|
|
|
|
|
)
|
|
|
|
)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if nested, ok := val.(map[string]interface{}); ok {
|
|
|
|
} else if nested, ok := val.(map[string]interface{}); ok {
|
|
|
|
var invalidKeys []string
|
|
|
|
invalidKeys := []string{}
|
|
|
|
for k := range nested {
|
|
|
|
for k := range nested {
|
|
|
|
if _, allowed := allowedKeys[k]; !allowed {
|
|
|
|
if _, allowed := allowedKeys[k]; !allowed {
|
|
|
|
invalidKeys = append(invalidKeys, k)
|
|
|
|
invalidKeys = append(invalidKeys, k)
|
|
|
|
}
|
|
|
|
|
|
|
|
}
|
|
|
|
|
|
|
|
if len(invalidKeys) > 0 {
|
|
|
|
|
|
|
|
ve.AddDetailWithSpan(
|
|
|
|
|
|
|
|
errors.ErrVariablesInvalidKey,
|
|
|
|
|
|
|
|
fmt.Sprintf(errors.ErrorMessages[errors.ErrVariablesInvalidKey], varName, strings.Join(invalidKeys, ", ")),
|
|
|
|
|
|
|
|
line, col, line, col+len(varName),
|
|
|
|
|
|
|
|
)
|
|
|
|
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if len(invalidKeys) > 0 {
|
|
|
|
}
|
|
|
|
ve.AddDetailWithSpan(errors.ErrVariablesInvalidKey,
|
|
|
|
}
|
|
|
|
fmt.Sprintf(errors.ErrorMessages[errors.ErrVariablesInvalidKey], varName, strings.Join(invalidKeys, ", ")),
|
|
|
|
|
|
|
|
0, 0, 0, 0)
|
|
|
|
func validateJobVariables(job *Job, ve *errors.ValidationError) {
|
|
|
|
|
|
|
|
if job.VariablesNode == nil {
|
|
|
|
|
|
|
|
return
|
|
|
|
|
|
|
|
}
|
|
|
|
|
|
|
|
if job.VariablesNode.Kind != yaml.MappingNode {
|
|
|
|
|
|
|
|
ve.AddDetailWithSpan(
|
|
|
|
|
|
|
|
errors.ErrVariablesInvalid,
|
|
|
|
|
|
|
|
"job variables should be a map",
|
|
|
|
|
|
|
|
job.Line, job.Column, job.Line, job.Column+1,
|
|
|
|
|
|
|
|
)
|
|
|
|
|
|
|
|
return
|
|
|
|
|
|
|
|
}
|
|
|
|
|
|
|
|
varsMap, ok := job.Variables.(map[string]interface{})
|
|
|
|
|
|
|
|
if !ok {
|
|
|
|
|
|
|
|
ve.AddDetailWithSpan(
|
|
|
|
|
|
|
|
errors.ErrVariablesInvalid,
|
|
|
|
|
|
|
|
"job variables should be a map",
|
|
|
|
|
|
|
|
job.Line, job.Column, job.Line, job.Column+1,
|
|
|
|
|
|
|
|
)
|
|
|
|
|
|
|
|
return
|
|
|
|
|
|
|
|
}
|
|
|
|
|
|
|
|
validateVariablesMap(varsMap, job.VariablesNode, ve, func(varName string) (int, int) {
|
|
|
|
|
|
|
|
// Ищем переменную в узле job.VariablesNode
|
|
|
|
|
|
|
|
for i := 0; i < len(job.VariablesNode.Content)-1; i += 2 {
|
|
|
|
|
|
|
|
keyNode := job.VariablesNode.Content[i]
|
|
|
|
|
|
|
|
if keyNode.Value == varName {
|
|
|
|
|
|
|
|
return keyNode.Line, keyNode.Column
|
|
|
|
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
} else {
|
|
|
|
|
|
|
|
ve.AddDetailWithSpan(errors.ErrVariableInvalid,
|
|
|
|
|
|
|
|
fmt.Sprintf(errors.ErrorMessages[errors.ErrVariableInvalid], varName),
|
|
|
|
|
|
|
|
0, 0, 0, 0)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return job.Line, job.Column // если не найдено, используем позицию job
|
|
|
|
|
|
|
|
})
|
|
|
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
func validateVariables(cfg *GitLabCIConfig, ve *errors.ValidationError) {
|
|
|
|
|
|
|
|
if cfg.VariablesNode == nil {
|
|
|
|
|
|
|
|
return
|
|
|
|
|
|
|
|
}
|
|
|
|
|
|
|
|
if cfg.VariablesNode.Kind != yaml.MappingNode {
|
|
|
|
|
|
|
|
ve.AddDetailWithSpan(
|
|
|
|
|
|
|
|
errors.ErrVariablesInvalid,
|
|
|
|
|
|
|
|
errors.ErrorMessages[errors.ErrVariablesInvalid],
|
|
|
|
|
|
|
|
0, 0, 0, 0,
|
|
|
|
|
|
|
|
)
|
|
|
|
|
|
|
|
return
|
|
|
|
|
|
|
|
}
|
|
|
|
}
|
|
|
|
varsMap, ok := cfg.Variables.(map[string]interface{})
|
|
|
|
|
|
|
|
if !ok {
|
|
|
|
|
|
|
|
ve.AddDetailWithSpan(
|
|
|
|
|
|
|
|
errors.ErrVariablesInvalid,
|
|
|
|
|
|
|
|
errors.ErrorMessages[errors.ErrVariablesInvalid],
|
|
|
|
|
|
|
|
0, 0, 0, 0,
|
|
|
|
|
|
|
|
)
|
|
|
|
|
|
|
|
return
|
|
|
|
|
|
|
|
}
|
|
|
|
|
|
|
|
validateVariablesMap(varsMap, cfg.VariablesNode, ve, func(varName string) (int, int) {
|
|
|
|
|
|
|
|
// Ищем в YAML узле переменной с именем varName
|
|
|
|
|
|
|
|
for i := 0; i < len(cfg.VariablesNode.Content)-1; i += 2 {
|
|
|
|
|
|
|
|
keyNode := cfg.VariablesNode.Content[i]
|
|
|
|
|
|
|
|
if keyNode.Value == varName {
|
|
|
|
|
|
|
|
return keyNode.Line, keyNode.Column
|
|
|
|
|
|
|
|
}
|
|
|
|
|
|
|
|
}
|
|
|
|
|
|
|
|
return 0, 0
|
|
|
|
|
|
|
|
})
|
|
|
|
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
func isScalar(val interface{}) bool {
|
|
|
|
func isScalar(val interface{}) bool {
|
|
|
|
@ -413,7 +335,6 @@ func validateJobs(cfg *GitLabCIConfig, ve *errors.ValidationError) {
|
|
|
|
validateJobRules(job, ve)
|
|
|
|
validateJobRules(job, ve)
|
|
|
|
validateJobWhen(job, ve)
|
|
|
|
validateJobWhen(job, ve)
|
|
|
|
validateJobOnly(job, ve)
|
|
|
|
validateJobOnly(job, ve)
|
|
|
|
validateJobVariables(job, ve)
|
|
|
|
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
if visibleCount == 0 {
|
|
|
|
if visibleCount == 0 {
|
|
|
|
@ -877,20 +798,3 @@ func validateIncludeRuleMap(m map[string]interface{}, ve *errors.ValidationError
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
|
|
// checkFinalEmptyLine проверяет, что файл заканчивается пустой строкой.
|
|
|
|
|
|
|
|
func checkFinalEmptyLine(content string, ve *errors.ValidationError) {
|
|
|
|
|
|
|
|
// Если содержимое не заканчивается символом новой строки...
|
|
|
|
|
|
|
|
if !strings.HasSuffix(content, "\n") {
|
|
|
|
|
|
|
|
lines := strings.Split(content, "\n")
|
|
|
|
|
|
|
|
lastLineIndex := len(lines)
|
|
|
|
|
|
|
|
lastLineContent := lines[lastLineIndex-1]
|
|
|
|
|
|
|
|
lineNum := lastLineIndex
|
|
|
|
|
|
|
|
colNum := len(lastLineContent) + 1
|
|
|
|
|
|
|
|
ve.AddDetailWithSpan(
|
|
|
|
|
|
|
|
errors.ErrMissingFinalNewline,
|
|
|
|
|
|
|
|
errors.ErrorMessages[errors.ErrMissingFinalNewline],
|
|
|
|
|
|
|
|
lineNum, colNum, lineNum, colNum,
|
|
|
|
|
|
|
|
)
|
|
|
|
|
|
|
|
}
|
|
|
|
|
|
|
|
}
|
|
|
|
|
